[
https://issues.apache.org/jira/browse/CASSANDRA-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193608#comment-13193608
]
Jonathan Ellis commented on CASSANDRA-3787:
-------------------------------------------
This doesn't quite preserve the intent which is to throw on *either* more than
1 clause, or the count body mismatch. Updated to this on commit:
{code}
. if (selectClause.size() != 1)
throw new InvalidRequestException("Only COUNT(*) and
COUNT(1) operations are currently supported.");
String columnName = selectClause.get(0).toString();
if (!columnName.equals("*") && !columnName.equals("1"))
throw new InvalidRequestException("Only COUNT(*) and
COUNT(1) operations are currently supported.");
{code}
> [patch] fix bad comparison of column name against * or 1
> --------------------------------------------------------
>
> Key: CASSANDRA-3787
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3787
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1
> Reporter: Dave Brosius
> Priority: Trivial
> Labels: cql
> Fix For: 1.1
>
> Attachments: bad_column_compare.diff
>
>
> code does
> (!selectClause.get(0).equals("*") && !selectClause.get(0).equals("1")))
> which is a ColumnDefinition against a string
> changed to
> String columnName = selectClause.get(0).toString();
> if (!columnName.equals("*") && !columnName.equals("1"))
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
