[
https://issues.apache.org/jira/browse/CASSANDRA-3805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195423#comment-13195423
]
Jonathan Ellis commented on CASSANDRA-3805:
-------------------------------------------
A couple thoughts after glancing at it:
- careful with the import reordering --
http://wiki.apache.org/cassandra/CodeStyle
- In some places we want to be clear we're using an ArrayList to be clear that
get(int) is efficient
- May be similar reasoning for HashMap (which requires only hashCode
definition; other Maps require Comparable)
- If we're cleaning up Y x = new Y() declarations, should we modernize to
guava's Maps.newHashMap et al?
> [patch] use collection interfaces in method signatures where possible
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-3805
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3805
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Dave Brosius
> Priority: Trivial
> Attachments: use_interfaces.diff
>
>
> Some methods are declared to return or take concrete collection classes when
> they don't need that specificity. Converted to collection interfaces, to
> reduce cohesion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
