[
https://issues.apache.org/jira/browse/CASSANDRA-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202875#comment-13202875
]
paul cannon commented on CASSANDRA-3639:
----------------------------------------
+1, although I agree the tests should probably move somewhere else. I worked a
bit on putting similar tests in the dtest2 framework, and checking which ranges
*actually* got streamed, but yeah, that's overkill for this.
I was a bit tripped up by the fact that {{calculateStreamAndFetchRanges}} is
only valid for ranges for a moving node itself, and not for calculating changes
for a remote node's movement (i.e., {{calculatePendingRanges}}), but that's ok,
because it's only used in that way. A comment to that effect would not go
amiss, though.
> Move streams too many data
> --------------------------
>
> Key: CASSANDRA-3639
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3639
> Project: Cassandra
> Issue Type: Improvement
> Affects Versions: 0.8.7
> Reporter: Fabien Rousseau
> Priority: Minor
> Fix For: 1.1
>
> Attachments:
> 0001-try-to-fix-move-streaming-too-many-data-unit-tests-v2.patch,
> 0001-try-to-fix-move-streaming-too-many-data-unit-tests.patch
>
>
> During a move operation, we observed that the node streamed most of its data
> and received all its data.
> We are running Cassandra 0.8.7 (plus a few patches)
> After reading the code related to "move", we found out that :
> - in StorageService.java, line 2002 and line 2004 => ranges are returned in
> a non ordered collection, but calculateStreamAndFetchRanges() method (line
> 2011) assume ranges are sorted, thus, resulting in wider ranges to be
> fetched/streamed
> We managed to isolate and reproduce this in a unit test.
> We also propose a patch which :
> - does not rely on any sort
> - adds a few unit tests (may not be exhaustive...)
> Unit tests are done only for RF=2 and for the "OldNetworkStrategyTopology".
> For the sake of simplicity, we've put them in OldNetworkStrategyTopologyTest,
> but they probably should be moved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
