[
https://issues.apache.org/jira/browse/CASSANDRA-2917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203558#comment-13203558
]
Sam Tunnicliffe commented on CASSANDRA-2917:
--------------------------------------------
Thanks Jonathan, your updated patch is a big improvement. I had wondered about
excluding the System keyspace, or even giving the getRangeKeySample a Keyspace
argument.
+1 on removing the Transform, I agree its very verbose and only went down that
route as I saw them used in a few other places in the codebase. I've cherry
picked your change & squashed the two to create a new patch, is that the way
things usually get handled when patches are reworked? (I did see the mail on
the dev list a few weeks back regarding rebase vs merge, but I have to admit I
stopped following it after a while).
Out of interest, what's the best branch to work off when creating small patches
like this? I branched off trunk initially, but it looks like your 2917 branch
didn't?
> expose calculate midrange for token in jmx
> ------------------------------------------
>
> Key: CASSANDRA-2917
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2917
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: Jackson Chung
> Assignee: Sam Tunnicliffe
> Priority: Minor
> Labels: lhf
> Fix For: 1.1
>
> Attachments: trunk-2917.txt
>
>
> currently there is no easy way to get midrange, especially for OPP. For
> simplicity, you could call OrderPreservingPartitioner.midpoint(Token, Token),
> that gives you a rough estimate (and you'd still need to remove non-utf8
> characters.)
> A more accurate but difficult way is to sample the keys in that range and
> pick the midpoint of those. We should expose that via jmx, because without
> this, supporting OPP w/o this is quite challenging.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
