[ 
https://issues.apache.org/jira/browse/CASSANDRA-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205881#comment-13205881
 ] 

Jonathan Ellis commented on CASSANDRA-3872:
-------------------------------------------

Isn't this patch kind of a wash?  The MIN_VALUE checks go away but in return we 
need to add extra isMarkedForDelete checks.

                
> Sub-columns removal is broken in 1.1
> ------------------------------------
>
>                 Key: CASSANDRA-3872
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3872
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.0
>            Reporter: Sylvain Lebresne
>            Assignee: Sylvain Lebresne
>             Fix For: 1.1.0
>
>         Attachments: 3872.patch
>
>
> CASSANDRA-3716 actually broke sub-columns deletion. The reason is that in 
> QueryFilter.isRelevant, we've switched in checking getLocalDeletionTime() 
> only (without looking for isMarkedForDelete). But for columns containers (in 
> this case SuperColumn), the default local deletion time when not deleted is 
> Integer.MIN_VALUE. In other words, a SC with only non-gcable tombstones will 
> be considered as not relevant (while it should).
> This is caught by two unit tests (RemoveSuperColumnTest and 
> RemoveSubColumnTest) that are failing currently.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to