[ 
https://issues.apache.org/jira/browse/CASSANDRA-3892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206729#comment-13206729
 ] 

Peter Schuller commented on CASSANDRA-3892:
-------------------------------------------

So for the record. Previous versions of the patch dabbled with terminology like 
"eligible for reads" when differentiating between them. However, I realized 
that it was conflating different issues and it felt cleaner to use some other 
term. "Joined" was the best I came up with; it's consistent with the other 
states we have, and it fits pretty well in the sense that it kind of does hit 
the nail on the head - the significance of a node in this state is that it is 
fully joined in the ring. It's not that it's "normal" for example, because of 
the fact that a moving endpoint is not normal. Nor is the primarily interesting 
property that it serves reads.

I feel fairly satisfied with this as a suggested initial step.

I'd like to start tackling the sub-tasks, but I will wait for some feedback on 
this first because I wouldn't want to do the others against a trunk without 
something like this first completed.
                
> improve TokenMetadata abstraction, naming - audit current uses
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-3892
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3892
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Peter Schuller
>            Assignee: Peter Schuller
>         Attachments: CASSANDRA-3892-draft-v2.txt, 
> CASSANDRA-3892-draft-v3.txt, CASSANDRA-3892-draft-v4.txt, 
> CASSANDRA-3892-draft.txt
>
>
> CASSANDRA-3417 has some background. I want to make the distinction more clear 
> between looking at the ring from different perspectives (reads, writes, 
> others) and adjust naming to be more clear on this. I also want to go through 
> each use case and try to spot any subtle pre-existing bugs that I almost 
> introduced in CASSANDRA-3417, had not Jonathan caught me.
> I will submit a patch soonish.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to