[ 
https://issues.apache.org/jira/browse/CASSANDRA-3967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218019#comment-13218019
 ] 

Sylvain Lebresne commented on CASSANDRA-3967:
---------------------------------------------

The problem is that most tests rely on the behavior of CFS.clearUnsafe to not 
remove sstables. Typically, in SSTableReaderTest, there is 'persistence' tests 
that use clearUnsafe followed by a loadNewSSTable to check we correctly reload 
sstables. CASSANDRA-3970 is another example where we rely on the sstable not 
being removed. Also ColumnFamilyStoreTest and RecoveryManagerTest.

The patch also seem to be breaking a test in DatabaseDescriptorTest 
(testTransKsMigration that doesn't fail without the patch) but that test 
doesn't use clearUnsafe so I'm not sure what's going on.
                
> Test fixes for Windows
> ----------------------
>
>                 Key: CASSANDRA-3967
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3967
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.1.0
>
>         Attachments: 3967.txt
>
>
> - SchemaLoader initializes CommitLog, creating empty segments; CleanupHelper 
> then errors out trying to delete them (because they are still open)
> - CFS.clearUnsafe resets the sstable generation but does not remove the 
> sstables involved, so Windows will error out trying to rename over the 
> existing ones

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to