[ 
https://issues.apache.org/jira/browse/CASSANDRA-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237628#comment-13237628
 ] 

Dave Brosius commented on CASSANDRA-4023:
-----------------------------------------

Getting NPE around this code (trunk).

SSTableReader.open on system-schema_columnfamilies-ib-2

SSTableReader.load bails out of the while (true) loop because

if (indexPosition == indexSize)

causing the right variable to remain null, which then gets passed to

this.last = getMinimalKey(right);

which NPEs

boolean lastKey = indexPosition + DBConstants.SHORT_SIZE + len + 
DBConstants.LONG_SIZE == indexSize; is false on the last item

indexPosition = 0
len = 9
indexSize = 23

19 != 23


public static DecoratedKey getMinimalKey(DecoratedKey key)
    {
        return key.key.position() > 0 || key.key.hasRemaining()
                                       ? new DecoratedKey(key.token, 
HeapAllocator.instance.clone(key.key))
                                       : key;
    }



                
> Improve BloomFilter deserialization performance
> -----------------------------------------------
>
>                 Key: CASSANDRA-4023
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4023
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Joaquin Casares
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: datastax_qa
>             Fix For: 1.0.9, 1.1.0
>
>         Attachments: 0001-fix-loading-promoted-row-index.patch, 4023.txt, 
> cassandra-1.0-4023-v2.txt, cassandra-1.0-4023-v3.txt
>
>
> The difference of startup times between a 0.8.7 cluster and 1.0.7 cluster 
> with the same amount of data is 4x greater in 1.0.7.
> It seems as though 1.0.7 loads the BloomFilter through a series of reading 
> longs out in a multithreaded process while 0.8.7 reads the entire object.
> Perhaps we should update the new BloomFilter to do reading in batch as well?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to