[
https://issues.apache.org/jira/browse/CASSANDRA-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250486#comment-13250486
]
Sylvain Lebresne commented on CASSANDRA-4100:
---------------------------------------------
bq. OK, so static Throttle is fine
I'll have to disagree. I'm pretty sure this patch break throttling. If more
than one compaction share the Throttle object, they also share the
Throttle.timeAtLastDelay field. Which means that as soon as there is more than
1 compaction running at any given time, the interval on which throttling is
computing is bogus, and thus throttling will be bogus.
More generally, I'm -1 on changing code that does not have any known problem on
the 1.0 branch (and as far as I know, current throttling works well) as 1.0 is
getting really stable and we should start being conservative there (but I'd be
fine with a patch that just add throttling to scrub and cleanup for 1.0).
> Make scrub and cleanup operations throttled
> -------------------------------------------
>
> Key: CASSANDRA-4100
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4100
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Labels: compaction
> Fix For: 1.0.10
>
> Attachments: 0001-CASSANDRA-4100-v2.patch, 0001-CASSANDRA-4100.patch
>
>
> Looks like scrub and cleanup operations are not throttled and it will be nice
> to throttle else we are likely to run into IO issues while running it on live
> cluster.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
