[ https://issues.apache.org/jira/browse/CASSANDRA-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267280#comment-13267280 ]
Sylvain Lebresne commented on CASSANDRA-4187: --------------------------------------------- bq. Where did the "min cannot be larger than max" checks move to? It's already in CFMetadata.validate() (i.e. it was duplicated) > CQL3: move {max/min}_compaction_thresholds to compaction options > ---------------------------------------------------------------- > > Key: CASSANDRA-4187 > URL: https://issues.apache.org/jira/browse/CASSANDRA-4187 > Project: Cassandra > Issue Type: Improvement > Components: API > Affects Versions: 1.1.0 > Reporter: Sylvain Lebresne > Assignee: Sylvain Lebresne > Priority: Trivial > Labels: cql3 > Fix For: 1.1.1 > > Attachments: 0001-Refactor-CFPropDefs-to-avoid-duplicate-code.txt, > 0002-Move-min-max-compaction-threshold-settings-to-compacti.txt > > > It makes way more sense to have min_compaction_threshold and > max_compaction_threshold be parts of the compaction_strategy_options. They > are not in thrift (and CQL2) only for historical reasons, but there is no > reason not to fix it. Especially given that they don't make sense for all > compaction strategy (Leveled compaction ignores them). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira