[
https://issues.apache.org/jira/browse/CASSANDRA-3762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vijay updated CASSANDRA-3762:
-----------------------------
Attachment: 0001-CASSANDRA-3762-v4.patch
I dont know why i decided to delete the debug messages :)
>>> KeyCacheSerializer.serializingSize(...) method uses
>>> AVERAGE_KEY_CACHE_ROW_SIZE where it should use an actual size of the
>>> serialized value.
If we get the real value, this will cause a cache Hit and another cache hit for
saving the value. We just need a estimate and we dont need to be accurate IMHO.
Added documentation for the same.
>>> in RowCacheTest.java deleted assert should be moved back because we really
>>> want to test the amount of read rows properly.
Fixed.
>>> AutoSavingCache.loadSaved(...) method should return if exception occurred
>>> while loading old style cache.
It does :)
>>> in the AutoSavingCache.loadSaved(...) deleted debug output should be
>>> returned because it's very useful for diagnostic purposes.
Fixed
>>> in the ColumnFamilyStore we really should check if we want to load the
>>> cache using (caching == Caching.NONE || caching == Caching.ROWS_ONLY).
>>> Right now that check if removed and the cache load is called even if there
>>> caching was disabled on the given ColumnFamily, the same also applies for
>>> the row cache.
It is harmless but Fixed!
>>> the following code could be changed (otherwise we would have ifs each time
>>> we add a new element):
Done!
> AutoSaving KeyCache and System load time improvements.
> ------------------------------------------------------
>
> Key: CASSANDRA-3762
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3762
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.2
>
> Attachments: 0001-CASSANDRA-3762-v2.patch,
> 0001-CASSANDRA-3762-v3.patch, 0001-CASSANDRA-3762-v4.patch,
> 0001-SavedKeyCache-load-time-improvements.patch
>
>
> CASSANDRA-2392 saves the index summary to the disk... but when we have saved
> cache we will still scan through the index to get the data out.
> We might be able to separate this from SSTR.load and let it load the index
> summary, once all the SST's are loaded we might be able to check the
> bloomfilter and do a random IO on fewer Index's to populate the KeyCache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
