[ 
https://issues.apache.org/jira/browse/CASSANDRA-4252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278357#comment-13278357
 ] 

Jonathan Ellis commented on CASSANDRA-4252:
-------------------------------------------

bq. just nicer to set the mode immediately so that when a move is initiated the 
operation mode of the node changes immediately rather than waiting 30ish seconds

Fair enough.

bq. in the admittedly uncommon case of no data being transferred the operation 
mode gets set to moving at all

I think it's inside that check to avoid logging "fetching new ranges and 
streaming old ranges" when there's nothing to stream, which is also misleading.

Since we don't "push" modes I don't think there's any difference between not 
setting it at all, and setting it only to set back to NORMAL a nanosecond later.
                
> Set operation mode to MOVING earlier
> ------------------------------------
>
>                 Key: CASSANDRA-4252
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4252
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Nick Bailey
>            Priority: Minor
>
> Right now when moving a node we set the OperationMode only once we've 
> calculated the necessary ranges to transfer and if there actually are ranges 
> to transfer. Due to the sleep for ring settling this means there are 30 
> seconds where the node is moving but the operation mode isn't set 
> accordingly. Additionally if it turns out no data needs to be transferred 
> then the move will complete without ever switching the OperationMode to 
> moving.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to