[ 
https://issues.apache.org/jira/browse/CASSANDRA-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280296#comment-13280296
 ] 

Yuki Morishita commented on CASSANDRA-4247:
-------------------------------------------

Oh, I missed that part. +1 then.

You also need to update test/data/1.2/ by doing {{ant msg-ser-gen-test}} since 
serialized format is changed for RSC. But that ant command fails because there 
is an error in MerkleTree serializedSize, so I pushed fix and new version of 
test data here: https://github.com/yukim/cassandra/commits/4247-4
                
> More-efficient serialization for IndexScanCommand and RangeSliceCommand
> -----------------------------------------------------------------------
>
>                 Key: CASSANDRA-4247
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4247
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jonathan Ellis
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 1.2
>
>         Attachments: 
> 0001-De-serialize-thrift-object-directly-from-to-stream.patch, 
> 0002-Fix-SerializationsTest.patch
>
>
> These two classes embed a Thrift struct to simplify de/serialization. This 
> means we serialize to byte[] twice on the write path: once to get the size, 
> and again to actually send the message.
> We should serialize manually like the other commands in VERSION_12.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to