[ https://issues.apache.org/jira/browse/CASSANDRA-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402025#comment-13402025 ]
Sylvain Lebresne commented on CASSANDRA-3974: --------------------------------------------- About the removeDeleted problem: I think that trying to force calls to removeDeleted (which force an iteration of all columns) so that we can add the logic of this ticket is the wrong approach (because it's inefficient for no good reason and doesn't make the code easier to follow). I.e. currently the code to ignore irrelevant columns is split between QueryFilter.isRelevant() and removeDeleted depending of which code path is taken (reads use isRelevant and compaction uses removeDeleted basically). So I see mostly 2 options: # we find a way to refactor the code so that we only ever ignore irrelevant columns in one place. That would be great but again it's unclear how to do that correctly. # we put the logic for this patch in both removeDeleted and isRelevant. I'm personally fine going the second solution for the purpose of this ticket and keep the first option in mind for later as a way to improve the code base. > Per-CF TTL > ---------- > > Key: CASSANDRA-3974 > URL: https://issues.apache.org/jira/browse/CASSANDRA-3974 > Project: Cassandra > Issue Type: New Feature > Affects Versions: 1.2 > Reporter: Jonathan Ellis > Assignee: Kirk True > Priority: Minor > Fix For: 1.2 > > Attachments: trunk-3974.txt, trunk-3974v2.txt, trunk-3974v3.txt > > > Per-CF TTL would allow compaction optimizations ("drop an entire sstable's > worth of expired data") that we can't do with per-column. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira