[
https://issues.apache.org/jira/browse/CASSANDRA-4357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402844#comment-13402844
]
Jonathan Ellis commented on CASSANDRA-4357:
-------------------------------------------
- Wouldn't it be simpler to use a single pattern with an optional group for the
new version, than two patterns?
- logic in getMessagingVersion could lead to errors if MS version bumps but
someone forgets to bump CLD. Would prefer a switch w/ specific CLD -> MS
versions (avoiding current_version) and a default: throw invalid.
Nits:
- would prefer to have convertOldCfId throw the more-specific UCFE, than
generic IOE
- SEPERATOR spelling
> Add Commitlog Versioning
> ------------------------
>
> Key: CASSANDRA-4357
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4357
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2
> Reporter: Vijay
> Assignee: Vijay
> Priority: Minor
> Fix For: 1.2
>
> Attachments: 0001-Allow-Commit-log-to-skip-unknownCF.patch,
> 0001-CASSANDRA-4357.patch, 0002-Add-CommitLog-versioning.patch
>
>
> Currently when there are changes in protocol version in RowMutation it is not
> handled in the Commit Logs.
> CASSANDRA-4139 adds changes which exposes this.
> It would be nice to reuse MessagingService.currentVersion to be the Commit
> Log version (encoded in the name) instead of creating a separate one.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
