[
https://issues.apache.org/jira/browse/CASSANDRA-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13410953#comment-13410953
]
Eric Evans commented on CASSANDRA-4125:
---------------------------------------
{quote}
[the -a arg is] in the description and might be a good idea, since people used
to pre-vnode cassandra might be a bit shocked when thousands of lines scroll by
when running it :)
{quote}
We could deprecate it, run it with a deprecation warning if num_tokens == 1,
and force an additional argument to be passed
(--yes-I-want-to-be-scroll-shocked) when num_tokens > 1.
The problem I have with showing only one token is that it's very misleading.
The "ring" has always been used to visualize topology in a world where there
was a 1:1 relationship between node and token. Displaying our classic ring
view with that 1:1 mapping when there are say hundreds of tokens seems almost
certain to cause confusion.
{quote}
If you want to move a node, you need ring to get the token. If you want to
remove a node, you need clusterinfo to get the hostid. And then if you want to
know dc/rack info, you're back to ring (even with vnodes, except now you get
scrollshocked.) It just seems like it'd be nice to get all the info you need
from one place, the way ring currently works.
{quote}
What if we removed "Load" from {{clusterinfo}} to free up a little real estate
(that seems like something people could get form {{info}}), added a "rack"
column, and then page the list by DC the way CASSANDRA-3047 aimed to?
{noformat}
Datacenter: DC1
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Address Rack Status State Tokens Owns Host ID
127.0.1.3 rack1 Up Normal 8 16.00%
aaaa59d9-e5f9-445e-bb4b-a29a55075698
127.0.2.2 rack2 Up Normal 8 16.00%
bbbb31c5-e7eb-43c5-8393-2b71cd90d361
127.0.3.1 rack3 Up Normal 8 16.00%
cccc0bee-7292-4adb-9eb5-1f3bfd6d6d92
Datacenter: DC2
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Address Rack Status State Tokens Owns Host ID
127.1.1.3 rack1 Up Normal 8 16.00%
dddd59d9-e5f9-445e-bb4b-a29a55075698
127.1.2.2 rack2 Up Normal 8 16.00%
eeee31c5-e7eb-43c5-8393-2b71cd90d361
127.1.3.1 rack3 Up Normal 8 16.00%
ffff0bee-7292-4adb-9eb5-1f3bfd6d6d92
{noformat}
> Update nodetool for vnodes
> --------------------------
>
> Key: CASSANDRA-4125
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4125
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Sam Overton
> Assignee: Eric Evans
>
> The proposed changes are intended to preserve backwards compatibility:
> || op || behaviour || deprecated warning?
> | join | Join the ring, use with {{-t}} to join at a specific token, or to
> add a token to an existing host |
> | ring | prints the first token for each node, add {{-a}} to print all tokens
> |
> | move <new token> | if the node only has 1 token then move it. Otherwise die
> with an error. | *deprecated*
> | removetoken status/force/<token> | removes the node who owns <token> from
> the ring. use {{-t}} option to only remove the token from the node instead of
> the whole node. |
> | describering [keyspace] | show all ranges and their endpoints |
> | getendpoints <keyspace> <cf> <key> | Print the endpoints that own the key
> and also their list of tokens |
> _Edit0: Appended patch information._
> h3. Patches
> ||Compare||Raw diff||Description||
> |[01_admin_tools|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools]|[01_admin_tools.patch|https://github.com/acunu/cassandra/compare/top-bases/p/4125/01_admin_tools...p/4125/01_admin_tools.diff]|Updated
> nodetool|
> ----
> _Note: These are branches managed with TopGit. If you are applying the patch
> output manually, you will either need to filter the TopGit metadata files
> (i.e. {{wget -O - <url> | filterdiff -x*.topdeps -x*.topmsg | patch -p1}}),
> or remove them afterward ({{rm .topmsg .topdeps}})._
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
