[ 
https://issues.apache.org/jira/browse/CASSANDRA-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412036#comment-13412036
 ] 

Jonathan Ellis commented on CASSANDRA-4234:
-------------------------------------------

I think we need a synchronized method in LeveledManifest to return a copy of 
generations[i].  Otherwise {{new ArrayList<SSTableReader>(manifest.getLevel(i)) 
}}can race and error out.

Nit: would rename canDropTombstone to something like worthDroppingTombstones
                
> Add tombstone-removal compaction to LCS
> ---------------------------------------
>
>                 Key: CASSANDRA-4234
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4234
>             Project: Cassandra
>          Issue Type: Improvement
>    Affects Versions: 1.2
>            Reporter: Jonathan Ellis
>            Assignee: Yuki Morishita
>            Priority: Minor
>              Labels: compaction
>             Fix For: 1.2
>
>         Attachments: 4234.txt
>
>
> CASSANDRA-3442 will recompact sstables with high levels of expired 
> tombstones, but only under SCS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to