[
https://issues.apache.org/jira/browse/CASSANDRA-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418130#comment-13418130
]
Sylvain Lebresne commented on CASSANDRA-3647:
---------------------------------------------
bq. When I try to do SET operation on any collection type I get following
exception
What would be useful is the query used to trigger that exception. I'll note
that there is some basic tests for this at
https://github.com/riptano/cassandra-dtest/blob/master/cql_tests.py (set_test,
list_test and map_test) which have some SET operation and are working
correctly. And btw, everyone is very much welcome to help adding/improving
those tests.
bq. attaching my alternative version
That refactor lgtm on principle, however:
* For lists, ListOperation.SET is used for both 'set a column to a literal' and
'set a list element by index', so setting a literal is broken. Nit: for map and
sets, the behavior of doSet() relay on the fallthrough of the switch statement,
it would be nice to add a comment explaining that the falltrhough is on purpose.
* In UpdateStatement.prepare(), you replaced the check !(value instanceof Term)
by operation.getType() == Operation.Type.COLUMN, which is reversed.
> Support set and map value types in CQL
> --------------------------------------
>
> Key: CASSANDRA-3647
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3647
> Project: Cassandra
> Issue Type: New Feature
> Components: API, Core
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Labels: cql
> Fix For: 1.2
>
> Attachments: CASSANDRA-3647-alternative.patch
>
>
> Composite columns introduce the ability to have arbitrarily nested data in a
> Cassandra row. We should expose this through CQL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
