[
https://issues.apache.org/jira/browse/CASSANDRA-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419879#comment-13419879
]
Aleksey Yeschenko commented on CASSANDRA-2116:
----------------------------------------------
{quote}
Looks like we should drop the "throws IOException" declaration from
applyIndexUpdates (and have that chain throw FSWE as needed).
{quote}
I think *SecondaryIndex methods should throw some kind of
SecondaryIndexException instead.
{quote}
SSTII should throw IOException when it doesn't know what DataInput is. Callers
can transform to FSRE. (Other constructors, or in the last case,
IncomingStreamReader.)
{quote}
Do you mean the constructor only? Because other methods (next, reset) in SSTII
implement Iterator/ICountableColumnIterator. Can't throw IOE. Can modify
ICountableColumnIterator, but not Iterator, for obvious reasons. Maybe throw
IOException from the constructor, but use instanceof and throw FSReadError in
reset and next?
{quote}
BTW: congratulations on getting import ordering (almost) correct on the first
try. The only thing missing is, com.google.common goes above org.slf4j instead
of being lumped in with "everything else."
{quote}
Thanks. Had to do _something_ almost right.
> Separate out filesystem errors from generic IOErrors
> ----------------------------------------------------
>
> Key: CASSANDRA-2116
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2116
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Chris Goffinet
> Assignee: Aleksey Yeschenko
> Fix For: 1.2
>
> Attachments:
> 0001-Issue-2116-Replace-some-IOErrors-with-more-informati.patch,
> 0001-Separate-out-filesystem-errors-from-generic-IOErrors.patch,
> CASSANDRA-2116-v3.patch
>
>
> We throw IOErrors everywhere today in the codebase. We should separate out
> specific errors such as (reading, writing) from filesystem into FSReadError
> and FSWriteError. This makes it possible in the next ticket to allow certain
> failure modes (kill the server if reads or writes fail to disk).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
