[
https://issues.apache.org/jira/browse/CASSANDRA-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439816#comment-13439816
]
Eric Evans commented on CASSANDRA-4383:
---------------------------------------
In so much that I fully understand the implications, it looks OK to me. A few
things:
You're using the presence of a hostID as an implicit indication of the version,
and a determination of whether or not to try decoding more than just the legacy
token. Going back to a test of the MS version might read better, and wouldn't
mask a bug where MS >= 1.2 but a host ID wasn't set.
In {{SS.bootstrap()}}, I think the TOKENS state should be set before the STATUS
normal. Also, since that's not the only place where the order of those 2
things matters, it might make sense to encapsulate that in a method, (or at the
very least, clearly comment them).
And, of course as you mention, there are the tests... :)
> Binary encoding of vnode tokens
> -------------------------------
>
> Key: CASSANDRA-4383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4383
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 1.2.0
>
> Attachments:
> 0001-Add-HOST_ID-and-TOKENS-app-states-binary-serialization.txt, 4383-v1.txt
>
>
> Since after CASSANDRA-4317 we can know which version a remote node is using
> (that is, whether it is vnode-aware or not) this a good opportunity to change
> the token encoding to binary, since with a default of 256 tokens per node
> even a fixed-length 16 byte encoding per token provides a great deal of
> savings in gossip traffic over a text representation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
