[
https://issues.apache.org/jira/browse/CASSANDRA-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444944#comment-13444944
]
Brandon Williams commented on CASSANDRA-4383:
---------------------------------------------
Quoting myself:
bq. The last wrinkle is the case of bootstrapping a node without using vnodes,
and without specifying a token. This technically still works, but produces a
harmless NPE on the existing nodes when they first see the state and look for
TOKENS. I'm hesitant to allow this to pass through though since it could paper
over a truly serious bug, and bootstrapping in this fashion is already
deprecated by vnodes.
I fixed that in this patch too, by simple confirming that TOKENS is actually
present for the host in handleStateBootstrap, and if not, just handle things
the old way since it's a legacy-style bootstrap.
> Binary encoding of vnode tokens
> -------------------------------
>
> Key: CASSANDRA-4383
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4383
> Project: Cassandra
> Issue Type: Sub-task
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Fix For: 1.2.0 beta 1
>
> Attachments:
> 0001-Add-HOST_ID-and-TOKENS-app-states-binary-serialization.txt,
> 0002-Fix-tests.txt
>
>
> Since after CASSANDRA-4317 we can know which version a remote node is using
> (that is, whether it is vnode-aware or not) this a good opportunity to change
> the token encoding to binary, since with a default of 256 tokens per node
> even a fixed-length 16 byte encoding per token provides a great deal of
> savings in gossip traffic over a text representation.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
