[ 
https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Description: 
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that 
statistic is very important, because it shows real server response time (with 
accounting of additional requests to other nodes). It can be usefull for 
gathering of the server response time statistics by some monitoring systems 
(without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' 
column. Output is not usable for parse because of that. I suggest to insert '0' 
instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      
Column Count
1             109298                 0                 0                 0      
   128700943
2                778                 0                 0                 0      
           0
....
1597                                 0               505                 0      
           0
1916                                 0               566                 0      
           0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      
Column Count
1             109298                 0                 0                 0      
   128700943
2                778                 0                 0                 0      
           0
....
1597               0                 0               505                 0      
           0
1916               0                 0               566                 0      
           0
{code}


PS: I've attached a patch that fixes all described problems. 

  was:
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that 
statistic is very important, because it shows real server response time (with 
accounting of additional requests to other nodes). It can be usefull for 
gathering of the server response time statistics by some monitoring systems 
(without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' 
column. Output is not usable for parse because of that. I suggest to insert '0' 
instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      
Column Count
1             109298                 0                 0                 0      
   128700943
2                778                 0                 0                 0      
           0
....
1597                                 0               505                 0      
           0
1916                                 0               566                 0      
           0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      
Column Count
1             109298                 0                 0                 0      
   128700943
2                778                 0                 0                 0      
           0
....
1597            0                     0               505                 0     
            0
1916            0                     0               566                 0     
            0
{code}


PS: I've attached a patch that fixes all described problems. 

    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that 
> statistic is very important, because it shows real server response time (with 
> accounting of additional requests to other nodes). It can be usefull for 
> gathering of the server response time statistics by some monitoring systems 
> (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 
> 'SSTables' column. Output is not usable for parse because of that. I suggest 
> to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size    
>   Column Count
> 1             109298                 0                 0                 0    
>      128700943
> 2                778                 0                 0                 0    
>              0
> ....
> 1597                                 0               505                 0    
>              0
> 1916                                 0               566                 0    
>              0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size    
>   Column Count
> 1             109298                 0                 0                 0    
>      128700943
> 2                778                 0                 0                 0    
>              0
> ....
> 1597               0                 0               505                 0    
>              0
> 1916               0                 0               566                 0    
>              0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to