[
https://issues.apache.org/jira/browse/CASSANDRA-4803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483522#comment-13483522
]
Jonathan Ellis edited comment on CASSANDRA-4803 at 10/24/12 7:58 PM:
---------------------------------------------------------------------
03 committed in CASSANDRA-4816.
Not sure about 04 -- I'm a fan of the simplifications we get from letting CFRR
only need to deal with non-wrapping splits.
was (Author: jbellis):
Not sure about 04 -- I'm a fan of the simplifications we get from letting
CFRR only need to deal with non-wrapping splits.
> CFRR wide row iterators improvements
> ------------------------------------
>
> Key: CASSANDRA-4803
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4803
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
> Affects Versions: 1.1.0
> Reporter: Piotr Kołaczkowski
> Assignee: Piotr Kołaczkowski
> Fix For: 1.1.7, 1.2.0 beta 2
>
> Attachments: 0001-Wide-row-iterator-counts-rows-not-columns.patch,
> 0002-Fixed-bugs-in-describe_splits.-CFRR-uses-row-counts-.patch,
> 0003-Fixed-get_paged_slice-memtable-and-sstable-column-it.patch,
> 0004-Better-token-range-wrap-around-handling-in-CFIF-CFRR.patch,
> 0005-Fixed-handling-of-start_key-end_token-in-get_range_s.patch,
> 0006-Code-cleanup-refactoring-in-CFRR.-Fixed-bug-with-mis.patch
>
>
> {code}
> public float getProgress()
> {
> // TODO this is totally broken for wide rows
> // the progress is likely to be reported slightly off the actual but
> close enough
> float progress = ((float) iter.rowsRead() / totalRowCount);
> return progress > 1.0F ? 1.0F : progress;
> }
> {code}
> The problem is iter.rowsRead() does not return the number of rows read from
> the wide row iterator, but returns number of *columns* (every row is counted
> multiple times).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
