[
https://issues.apache.org/jira/browse/CASSANDRA-4904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-4904:
----------------------------------------
Attachment: 4904.txt
Patch attached. It's not perfect in the sense that I've added
expressionString() to AbstractSimplePerColumnSecondaryIndex rather than
SecondaryIndex directly, which forces a cast in the searchers, but I wanted to
avoid "polluting" SecondaryIndex just for that since that would force custom
index implementation to index the method even though that doesn't make sense.
Truth is, I think the right fix would probably be to make the searchers
(KeysSearcher and CompositeSearcher) ctor take their actual Secondary index
implementation (i.e. KeysIndex and CompoisteIndex respectively) as argument
instead of the SecondayIndexManager, which would also avoid the SecondaryIndex
lookup later on. But SecondaryIndexManager does things related to the searcher
that I don't really understand so I'd rather left a potential refactor of that
to later.
> log index scan subject in CompositesSearcher
> --------------------------------------------
>
> Key: CASSANDRA-4904
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4904
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.2.0 beta 1
> Reporter: Jonathan Ellis
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: 4904.txt
>
>
> Would like to do the equivalent of this from KeysSearcher:
> {code}
> if (logger.isDebugEnabled())
> logger.debug("Most-selective indexed predicate is on {}",
> baseCfs.getComparator().getString(primary.column_name));
> {code}
> Not sure how to figure out what part of the comparator the indexed name
> belongs to here, with which to getString it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
