[ 
https://issues.apache.org/jira/browse/CASSANDRA-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494561#comment-13494561
 ] 

Dave Brosius commented on CASSANDRA-4848:
-----------------------------------------

If BlacklistedDirectories constructor does throw an exception it is thrown at 
the time of class loading which is really confusing, as it is instantiated from 
the static singleton instance. perhaps logger in exception block would be 
warranted.

instance could be private

otherwise, lgtm

--not part of this patch, but for getDirectory it would seem a path with any 
extension should be assumed to be a file--




                
> Expose black-listed directories via JMX
> ---------------------------------------
>
>                 Key: CASSANDRA-4848
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4848
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0 beta 1
>            Reporter: Kirk True
>            Assignee: Kirk True
>            Priority: Minor
>              Labels: lhf
>             Fix For: 1.2.0 rc1
>
>         Attachments: trunk-4848.txt
>
>
> JBOD support included failure modes (CASSANDRA-2118) that insert directories 
> on bad disks to the {{BlacklistedDirectories}} class. However, it doesn't 
> appear that the list of directories is exposed to administrators via JMX or 
> other means. So unless they're scouring the logs or being notified at the OS 
> level, they will remain unaware of the issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to