[ 
https://issues.apache.org/jira/browse/CASSANDRA-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494575#comment-13494575
 ] 

Pavel Yaskevich commented on CASSANDRA-4942:
--------------------------------------------

Let's agree to disagree. My idea of this is that it should be done 
transparently so we don't duplicate the code in getSegment per implementation, 
and I don't like involving PooledSegmentedFile inside of RAR as well. Caller 
shouldn't care what instance it gets when it calls open. I didn't bother doing 
caching for RAR because the default disk_access_node is mmap which is 
considered a good practice and keeping caching changes local to CRAR (which has 
the most overhead per open) allows to reuse caches basically for everything. 

If you think that this is the right way to go, +1.
                
> Pool [Compressed]RandomAccessReader on the partitioned read path
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-4942
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4942
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.1
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to