[ 
https://issues.apache.org/jira/browse/CASSANDRA-5041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528067#comment-13528067
 ] 

Carl Yeksigian commented on CASSANDRA-5041:
-------------------------------------------

I see your point on the temp file -- I've removed that. Was being a little 
opportunistic, but since it doesn't really make sense in 99% of the cases, 
doesn't matter.

Yes, it will do the right thing if an sstable is mentioned in the manifest, but 
not present since it compares the sstables present against the members. Also, 
the other way works: if an sstable is present but not mentioned, it will not be 
loaded into a level (and thus treated as level 0).

I've also updated my code style.
                
> Change LeveledManifest to try to load old and tmp json files
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-5041
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5041
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Carl Yeksigian
>              Labels: leveled
>             Fix For: 1.2.1
>
>         Attachments: 5041.txt, 5041-v2.patch
>
>
> Even though leveled compaction creates an old and a tmp file while writing 
> out a new file, the leveled manifest does not attempt to load those files.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to