[
https://issues.apache.org/jira/browse/CASSANDRA-5043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528816#comment-13528816
]
Sylvain Lebresne commented on CASSANDRA-5043:
---------------------------------------------
bq. ABSC still looks better than TMBSC in practice.
Again, I'm not contesting that! But saying it 10 times won't change the fact
that ABSC currently throw an assertion if you insert columns out of order, and
that columnTimeOrderedData does that kind of out-of-order insertions.
As for the performance part, I was not necessarily in favor of adding the
assertion in the first place for that very reason, and yes, because this is for
names queries, and a such the number of columns is unlikely to be very large,
ABSC (without the assertion) would almost surely be always faster than TMBSC.
Though as said in my first comment, in term of complexity, aggregating all the
result of each sstable (so all in order) in a first ABSC first and then using
addAll() to merge it to a result ABSC would be better (and that latter solution
can be done without even removing the ABSC assertion).
> Small CollationController refactoring and CFS.getRawCachedRow(DecoratedKey)
> fix.
> --------------------------------------------------------------------------------
>
> Key: CASSANDRA-5043
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5043
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Pavel Yaskevich
> Assignee: Pavel Yaskevich
> Priority: Minor
> Fix For: 1.2.0
>
> Attachments: CASSANDRA-5043.patch
>
>
> CollactionController can construct a factory on init based on mutableColumns
> parameter. ArrayBackedSortedColumns proven to be better for counters as well
> as normal columns (row size from 5 to 75 columns). CFS.getRawCachedRow would
> copy key byte array each time it contracts a RowCacheKey so we want to avoid
> that where possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
