[
https://issues.apache.org/jira/browse/CASSANDRA-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528977#comment-13528977
]
Sylvain Lebresne commented on CASSANDRA-5031:
---------------------------------------------
Hum, that version add a bunch of stuff I'm not sure I understand:
* Why don't we reuse the SSLFactory.createSSLContext method? The patch makes it
public so I suspect that was the intention but the patch doesn't do it.
* This may be linked to the reconnection problems you mention, but not sure I
understand this SslStateHandler:
** First, I'm pretty sure you don't need to call handshake() especially if
SslHandler.setIssueHandsake(true) has been called. And reading the javadoc of
SSLEngine.beginHandshake (which handshake() calls) suggests that you don't even
need to call it at all unless you do renogetiation. The only other reason to
call handshake in Netty that I know of would be to know when the handshake is
done, but I don't think we care about that here because we won't write anything
on the wire anyway until everything is ready anyway.
** Then even if we happen to call handshake for some reason that I miss, I'm
not sure why we put the channel in a ChannelGroup that as far as I can tell we
don't use at all.
** I'm also unclear on why this handler should be between the message
decoders and the dispatcher. If we really need to do something ssl related when
a channel is connected (which again I'm not sure we do, though I could be
wrong), why not just extends SslHandler and override it's channelConnected
method? In particular we'll avoid that pipeline duplication (that I'd really
rather avoid, including for the client side).
bq. Should I avoid doing that for existing classes as that makes the diff
noisier?
In theory, we do try to avoid it if it's too much noise (which is subjective),
and prefer leaving code style fixes to there own separate patches. Not a big
deal though and if it doesn't hide too much the actual fixes it's fine.
> Add ssl support to binary protocol
> ----------------------------------
>
> Key: CASSANDRA-5031
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5031
> Project: Cassandra
> Issue Type: New Feature
> Components: API
> Reporter: Jonathan Ellis
> Assignee: Jason Brown
> Fix For: 1.2.1
>
> Attachments:
> 0001-CASSANDRA-5031-add-ssl-support-to-cql-binary-protoco.patch,
> 0002-CASSANDRA-5031_round2.patch
>
>
> CASSANDRA-4239 added support in Thrift
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
