[ 
https://issues.apache.org/jira/browse/CASSANDRA-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13551163#comment-13551163
 ] 

Sylvain Lebresne commented on CASSANDRA-5137:
---------------------------------------------

The code of v2 looks alright, but let's also disable the filtering in 
ColumnFamilyStore.ctor for non-counter CFs so we take zero chance of losing 
data (and since reusing an already compacted sstable is a bit inefficient but 
harmless).

bq. For 1.2, let's open different issue for Jonathan's suggestion

Agreed.
                
> Make sure SSTables left over from compaction get deleted and logged
> -------------------------------------------------------------------
>
>                 Key: CASSANDRA-5137
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5137
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>            Priority: Minor
>             Fix For: 1.1.9, 1.2.1
>
>         Attachments: 5137-1.1.txt, 5137-1.1-v2.txt
>
>
> When opening ColumnFamily, cassandra checks SSTable files' ancestors and 
> skips loading already compacted ones. Those files are expected to be deleted, 
> but currently that never happens.
> Also, there is no indication of skipping loading file in the log, so it is 
> confusing especially doing upgradesstables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to