[ 
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13553498#comment-13553498
 ] 

Dave Brosius edited comment on CASSANDRA-4795 at 1/15/13 5:23 AM:
------------------------------------------------------------------

the 'right'?? solution perhaps is to remove the cfs from 
AbstractCompactionStrategy ctor, and instead pass it into the various methods 
that need it. Problem there is that you'd need a 
'postCreateInitialize(ColumnFamilyStore cfs)' on ACS, as SizeTiered and Leveled 
do things with cfs in the ctor, that would need to move to that method.

It would also break backwards compatibility with potential client ACS's.
                
      was (Author: dbrosius):
    the 'right'?? solution perhaps is to remove the cfs from 
AbstractCompactionStrategy ctor, and instead pass it into the various methods 
that need it. Problem there is that you'd need a 
'postCreateInitialize(ColumnFamilyStore cfs)' on ACS, as SizeTiered and Leveled 
do things with cfs in the ctor, that would need to move to that method.
                  
> replication, compaction, compression? options are not validated
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-4795
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Brandon Williams
>            Assignee: Dave Brosius
>            Priority: Minor
>             Fix For: 1.2.1
>
>         Attachments: 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any 
> k/v pair you like.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to