[ 
https://issues.apache.org/jira/browse/CASSANDRA-5151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aleksey Yeschenko reopened CASSANDRA-5151:
------------------------------------------


After this commit (aa90c88be14b337714739cd857c12cad2a9fedeb) two tests started 
failing from time to time (not 100% consistently, bit noticeably often):

1. ColumnFamilyStoreTest

{noformat}
    [junit] Testsuite: org.apache.cassandra.db.ColumnFamilyStoreTest
    [junit] Tests run: 28, Failures: 0, Errors: 0, Time elapsed: 5.919 sec
    [junit] 
    [junit] ------------- Standard Error -----------------
    [junit]  WARN 04:11:00,492 setting live ratio to maximum of 64.0 instead of 
102.56071964017991
    [junit]  WARN 04:11:00,610 setting live ratio to maximum of 64.0 instead of 
303.2307692307692
    [junit] ERROR 04:11:01,182 Fatal exception in thread 
Thread[CompactionExecutor:2,1,main]
    [junit] java.lang.AssertionError: Incoherent new size -3 replacing 
[SSTableReader(path='build/test/cassandra/data/Keyspace1/Standard1/Keyspace1-Standard1-ib-4-Data.db'),
 
SSTableReader(path='build/test/cassandra/data/Keyspace1/Standard1/Keyspace1-Standard1-ib-3-Data.db'),
 
SSTableReader(path='build/test/cassandra/data/Keyspace1/Standard1/Keyspace1-Standard1-ib-6-Data.db'),
 
SSTableReader(path='build/test/cassandra/data/Keyspace1/Standard1/Keyspace1-Standard1-ib-5-Data.db')]
 by 
[SSTableReader(path='build/test/cassandra/data/Keyspace1/Standard1/Keyspace1-Standard1-ib-7-Data.db')]
 in View(pending_count=1, sstables=[], compacting=[])
    [junit]     at 
org.apache.cassandra.db.DataTracker$View.newSSTables(DataTracker.java:545)
    [junit]     at 
org.apache.cassandra.db.DataTracker$View.replace(DataTracker.java:517)
    [junit]     at 
org.apache.cassandra.db.DataTracker.replace(DataTracker.java:320)
    [junit]     at 
org.apache.cassandra.db.DataTracker.replaceCompactedSSTables(DataTracker.java:227)
    [junit]     at 
org.apache.cassandra.db.ColumnFamilyStore.replaceCompactedSSTables(ColumnFamilyStore.java:1030)
    [junit]     at 
org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:251)
    [junit]     at 
org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
    [junit]     at 
org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28)
    [junit]     at 
org.apache.cassandra.db.compaction.CompactionTask.execute(CompactionTask.java:72)
    [junit]     at 
org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:193)
    [junit]     at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:439)
    [junit]     at 
java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
    [junit]     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
    [junit]     at 
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    [junit]     at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    [junit]     at java.lang.Thread.run(Thread.java:680)
    [junit] ------------- ---------------- ---------------
{noformat}

2. CompactionsTest

{noformat}
   [junit] Testsuite: org.apache.cassandra.db.compaction.CompactionsTest
    [junit] Tests run: 9, Failures: 1, Errors: 0, Time elapsed: 20.298 sec
    [junit] 
    [junit] ------------- Standard Error -----------------
    [junit]  WARN 04:14:16,985 setting live ratio to maximum of 64.0 instead of 
360.7111111111111
    [junit]  WARN 04:14:17,121 setting live ratio to maximum of 64.0 instead of 
365.15555555555557
    [junit] ------------- ---------------- ---------------
    [junit] Testcase: 
testCompactionLog(org.apache.cassandra.db.compaction.CompactionsTest):    FAILED
    [junit] null
    [junit] junit.framework.AssertionFailedError
    [junit]     at 
org.apache.cassandra.db.compaction.CompactionsTest.testCompactionLog(CompactionsTest.java:311)
    [junit] 
    [junit] 
    [junit] Test org.apache.cassandra.db.compaction.CompactionsTest FAILED
{noformat}
                
> Implement better way of eliminating compaction left overs.
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-5151
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5151
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.1.3
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 1.2.2
>
>         Attachments: 5151-1.2.txt, 5151-v2.txt
>
>
> This is from discussion in CASSANDRA-5137. Currently we skip loading SSTables 
> that are left over from incomplete compaction to not over-count counter, but 
> the way we track compaction completion is not secure.
> One possible solution is to create system CF like:
> {code}
> create table compaction_log (
>   id uuid primary key,
>   inputs set<int>,
>   outputs set<int>
> );
> {code}
> to track incomplete compaction.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to