[
https://issues.apache.org/jira/browse/CASSANDRA-4795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylvain Lebresne updated CASSANDRA-4795:
----------------------------------------
Attachment: 0003-Adds-application_metadata-field-to-ks-metadata.txt
0002-Reallow-unexpected-strategy-options-for-thrift.txt
0001-Reallow-unexpected-strategy-options-for-thrift.txt
I'm a little bit confused about what you are trying to say. If you're saying
we've broke stuff in a minor release, it's bad, we should revert the breakage,
then I though I had made it pretty clear that I agree. But for 2.0 onwards,
allowing to store random data in the replication strategy option *is* wrong: it
doesn't even work with NTS (which will interpret the random data as a
datacenter).
But anyway, less arguing more doing, I'm attaching patches that do the
following:
* patch 00001 re-allow unknown options in the replication strategy options on
the thrift side (but not for CQL3 as I doubt there is any legacy CQL3 app using
this since CQL3 is kind of new). It also allows startup if there was unknown
options in the first place (that part was definitevely an oversight, the
compaction strategy is clearly making sure to only log a warning in that case
for instance).
* patch 00002 does the same for the compaction strategy.
* patch 00003 is my suggestion for an alternative to the problem "I want to
attach some tiny piece of metadata to a keyspace and creating a CF for that is
overkill" (for that patch the thrift file must be regen but I don't attach
that). Could totally go into a separate ticket.
Those patches are against 1.2 but to be clear, my intent is to keep disallowing
unknown options even for thrift in trunk.
> replication, compaction, compression? options are not validated
> ---------------------------------------------------------------
>
> Key: CASSANDRA-4795
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4795
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Dave Brosius
> Priority: Minor
> Fix For: 1.2.1
>
> Attachments: 0001-Reallow-unexpected-strategy-options-for-thrift.txt,
> 0002-Reallow-unexpected-strategy-options-for-thrift.txt,
> 0003-Adds-application_metadata-field-to-ks-metadata.txt,
> 4795.compaction_strategy.txt, 4795_compaction_strategy_v2.txt,
> 4795_compaction_strategy_v3.txt, 4795.replication_strategy.txt
>
>
> When creating a keyspace and specifying strategy options, you can pass any
> k/v pair you like.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
