[ 
https://issues.apache.org/jira/browse/CASSANDRA-5074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580256#comment-13580256
 ] 

Sylvain Lebresne commented on CASSANDRA-5074:
---------------------------------------------

To be honest, I'm not completely convinced about that NoCompactionStrategy 
idea. I agree with the ticket premises than using min/max thresholds is adhoc, 
especially since those threshold have no other meaning for leveled compaction.  
However, as Andrea says, we only want to disable automatic (background) 
compaction, not the user triggered ones, so replacing the strategy entirely 
feels overkill to me. Overall, a simple boolean in ColumnFamilyStore would seem 
much simpler to me. And since we already have the disableAutoCompaction call in 
JMX (for some reason it doesn't seem the enableAutoCompaction is expose in JMX 
so we should add it), I'd suggest using that as the sole way to enable/disable 
auto compactions.

                
> Add an official way to disable compaction
> -----------------------------------------
>
>                 Key: CASSANDRA-5074
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5074
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Priority: Minor
>             Fix For: 1.2.2
>
>
> We've traditionally used "min or max compaction threshold = 0" to disable 
> compaction, but this isn't exactly intuitive and it's inconsistently 
> implemented -- allowed from jmx, not allowed from cli.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to