[ 
https://issues.apache.org/jira/browse/CASSANDRA-5289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595406#comment-13595406
 ] 

Jackson Chung commented on CASSANDRA-5289:
------------------------------------------

I understand your point. 

We had a EC2 node outage last week, and subsequently the ops team rebuilt a 
node to replace it. 

However, I am not part of the ops team and so wasn't aware of such happened. 
But I was reviewing the logs for other issues, and reaching here was really 
confusing. (i saw node was started with new token indicating a new start, but 
then saw the log msg seems suggesting there were data).

Hence I would prefer keep the log but fix the bug to make it clear, instead of 
seeking for that sub nanoseconds improvement. But I would agree taking the log 
out would make it less confusing and gain that sub nanoseconds improvement.

Either way, your call :)
                
> DatabaseDescriptor.hasExistingNoSystemTables return true even with only 
> system keyspace
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5289
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5289
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jackson Chung
>            Priority: Minor
>         Attachments: 5289.diff
>
>
> The hasExistingNoSystemTables method in DatabaseDescriptor checks for 
> directory only. 
> On a new start, system KS would be created. This method current return true 
> because of it, resulting incorrect/confusing log:
>  logger.info("Found table data in data directories. Consider using the CLI to 
> define your schema.")     ;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to