[ 
https://issues.apache.org/jira/browse/CASSANDRA-5228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595908#comment-13595908
 ] 

Sylvain Lebresne commented on CASSANDRA-5228:
---------------------------------------------

I've only skimmed over the patch quickly, but while that looks fine on 
principle, one thing that is not ok is:
{noformat}
+            int maxLocalDeletionTime = desc.version.tracksMaxLocalDeletionTime 
? dis.readInt() : Integer.MIN_VALUE;
{noformat}
If !tracksMaxLocalDeletionTime, this should return Integer.MAX_VALUE, because 
MIN_VALUE means "everything in that sstable is GCable".

                
> Track maximum ttl and use to expire entire sstables
> ---------------------------------------------------
>
>                 Key: CASSANDRA-5228
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5228
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Jonathan Ellis
>            Assignee: Marcus Eriksson
>            Priority: Minor
>         Attachments: 0001-track-max-local-deletiontime-v2.patch, 
> 0001-track-max-ttl-v1.patch
>
>
> It would be nice to be able to throw away entire sstables worth of data when 
> we know that it's all expired.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to