add logging of data directories and multithreaded_compaction patch by Joaquin Casares; reviewed by jbellis for CASSANDRA-4570
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/416f80d8 Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/416f80d8 Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/416f80d8 Branch: refs/heads/trunk Commit: 416f80d82eabc2c65ece41a0d781f101625582f2 Parents: 8daa5d2 Author: Jonathan Ellis <[email protected]> Authored: Thu Mar 7 18:08:59 2013 +0000 Committer: Jonathan Ellis <[email protected]> Committed: Thu Mar 7 15:09:48 2013 -0600 ---------------------------------------------------------------------- .../cassandra/config/DatabaseDescriptor.java | 8 +++++--- .../apache/cassandra/service/CassandraDaemon.java | 3 +++ 2 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cassandra/blob/416f80d8/src/java/org/apache/cassandra/config/DatabaseDescriptor.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java index e5afe56..827805d 100644 --- a/src/java/org/apache/cassandra/config/DatabaseDescriptor.java +++ b/src/java/org/apache/cassandra/config/DatabaseDescriptor.java @@ -146,8 +146,8 @@ public class DatabaseDescriptor Yaml yaml = new Yaml(new Loader(constructor)); conf = (Config)yaml.load(input); - if (!System.getProperty("os.arch").contains("64")) - logger.info("32bit JVM detected. It is recommended to run Cassandra on a 64bit JVM for better performance."); + logger.info("Data files directories: " + Arrays.toString(conf.data_file_directories)); + logger.info("Commit log directory: " + conf.commitlog_directory); if (conf.commitlog_sync == null) { @@ -393,7 +393,9 @@ public class DatabaseDescriptor logger.debug("setting auto_bootstrap to " + conf.auto_bootstrap); } - if (conf.in_memory_compaction_limit_in_mb != null && conf.in_memory_compaction_limit_in_mb <= 0) + logger.info((conf.multithreaded_compaction ? "" : "Not ") + "using multi-threaded compaction"); + + if (conf.in_memory_compaction_limit_in_mb != null && conf.in_memory_compaction_limit_in_mb <= 0) { throw new ConfigurationException("in_memory_compaction_limit_in_mb must be a positive integer"); } http://git-wip-us.apache.org/repos/asf/cassandra/blob/416f80d8/src/java/org/apache/cassandra/service/CassandraDaemon.java ---------------------------------------------------------------------- diff --git a/src/java/org/apache/cassandra/service/CassandraDaemon.java b/src/java/org/apache/cassandra/service/CassandraDaemon.java index 16a9e47..8e617c4 100644 --- a/src/java/org/apache/cassandra/service/CassandraDaemon.java +++ b/src/java/org/apache/cassandra/service/CassandraDaemon.java @@ -119,6 +119,9 @@ public class CassandraDaemon */ protected void setup() { + // log warnings for different kinds of sub-optimal JVMs. tldr use 64-bit Oracle >= 1.6u32 + if (!System.getProperty("os.arch").contains("64")) + logger.info("32bit JVM detected. It is recommended to run Cassandra on a 64bit JVM for better performance."); String javaVersion = System.getProperty("java.version"); String javaVmName = System.getProperty("java.vm.name"); logger.info("JVM vendor/version: {}/{}", javaVmName, javaVersion);
