[
https://issues.apache.org/jira/browse/CASSANDRA-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13646451#comment-13646451
]
Sylvain Lebresne commented on CASSANDRA-5489:
---------------------------------------------
bq. unless you are suggesting to serialize key/column aliases lists as '[]' in
cases where there have been no renames and not '[null, null, null]' as it is
now in trunk
Yes, that is what I'm suggesting (basically we'll be in a state where either
all or none of your aliases are set, and so we'd just keep an empty list for
the 'none' case). But that will require a few tweaking on trunk, so my plan was
to first commit the simple patch to 1.2 asap if we're good with that (so it
gets release with 1.2.5 for instance) and merge it to trunk.
Then, I'll update trunk using the new all-or-nothing assumption (and making
sure we don't serialize nulls in particular). And I'll fix the ALTER with
metadata-less while I'm at it.
bq. Also, we still need to apply the cqlsh part of the v1 patch
Absolutely. Again, the patch for trunk I'm suggesting is not written yet. I
just wanted to get the "fix" for 1.2 out first, as that's somewhat more urgent.
bq. it can actually to to 1.2, with an added benefit that 1.2 cqlsh will be
able to properly describe 2.0 schema
That's a good idea. Though on that part, shouldn't we handle the case where the
schema don't have a 'type' column (since 'type' is only there in trunk)?
> Fix 2.0 key and column aliases serialization and cqlsh DESC SCHEMA
> ------------------------------------------------------------------
>
> Key: CASSANDRA-5489
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5489
> Project: Cassandra
> Issue Type: Bug
> Components: Core, Tools
> Affects Versions: 2.0
> Reporter: Aleksey Yeschenko
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 2.0
>
> Attachments: 5489-1.2.txt, 5489.txt
>
>
> CASSANDRA-5125 made a slight change to how key_aliases and column_aliases are
> serialized in schema. Prior to that we never kept nulls in the the json
> pseudo-lists. This does break cqlsh and probably breaks 1.2 nodes receiving
> such migrations as well. The patch reverts this behavior and also slightly
> modifies cqlsh itself to ignore non-regular columns from
> system.schema_columns table.
> This patch breaks nothing, since 2.0 already handles 1.2 non-null padded
> alias lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
