[ 
https://issues.apache.org/jira/browse/CASSANDRA-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carl Yeksigian updated CASSANDRA-5564:
--------------------------------------

    Attachment: 5564-v2.patch

This seems to improve the readability of the memory size overall.

I thought that the ObjectSizes class could use some comments.

Also, adding comments so that it is easier to figure out where each of the 
additions is coming from. Also switched to using the TypeSizes instead of just 
adding seeming arbitrary numbers (plus adds a little self documentation since 
the field name is included).

There was also another small bug in the RowIndexEntry; it was adding a 
reference to the size of position. There is only a single long in the class 
other than a static. This wouldn't significantly overallocate, but just seemed 
like it should be fixed.
                
> fix memorySize bugs
> -------------------
>
>                 Key: CASSANDRA-5564
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5564
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 1.2.5
>            Reporter: Jonathan Ellis
>            Assignee: Carl Yeksigian
>             Fix For: 1.2.5
>
>         Attachments: 5564.txt, 5564-v2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to