[
https://issues.apache.org/jira/browse/CASSANDRA-5625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679057#comment-13679057
]
Jonathan Ellis commented on CASSANDRA-5625:
-------------------------------------------
bq. StorageService has a Tracing.instance() call - it should trace something or
can be removed?
The docstring suggests (incorrectly) that the instance is lazily initialized;
my guess is this was a way to force initialization.
{code}
/**
* Fetches and lazy initializes the trace context.
*/
public static Tracing instance()
{
return instance;
}
{code}
> Cleanup Tracing class
> ---------------------
>
> Key: CASSANDRA-5625
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5625
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Mikhail Mazursky
> Priority: Trivial
> Attachments: trunk-5625.patch
>
>
> 1. Tracing instance cannot be null because it's initialized at classloading
> time and never changes. Made it final to prove that. Removed all redundant
> null checks.
> 2. StorageService has a Tracing.instance() call - it should trace something
> or can be removed?
> 3. Made sessions a ConcurrentMap to stress that it should be thread-safe.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
