[ 
https://issues.apache.org/jira/browse/CASSANDRA-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698314#comment-13698314
 ] 

Jason Brown commented on CASSANDRA-5719:
----------------------------------------

Seems fair to hook into thrift to kill the session when the connection dies.  
However, even if we did go with my solution and just shoot the ClientState, we 
would just build a new one the next time TSM.currentSession() is called - 
although I think we'll drop all the session info (like keyspace and such), so, 
yeah, not the best :). 

I'll rummage around in thrift to see if I can find something reasonable.


                
> Expire entries out of ThriftSessionManager
> ------------------------------------------
>
>                 Key: CASSANDRA-5719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5719
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Jason Brown
>            Assignee: Jason Brown
>            Priority: Minor
>              Labels: cache, thrift
>             Fix For: 1.2.7, 2.0 beta 1
>
>         Attachments: 5719-v1.patch
>
>
> TSM maintains a map of SocketAddress (IpAddr, and the ephemeral port) to 
> ClientState. If the connection goes away, for whatever reason, entries are 
> not removed from the map. In most cases this is a tiny leakage. However, at 
> Netflix, we auto-scale services up and down everyday, sometimes with client 
> instance lifetimes of around 36 hours. These clusters can add hundreds of 
> servers at peak time, and indescriminantly terminate them at the trough. 
> Thus, those Ip addresses are never coming back (for us). The net effect for 
> cassandra is that we'll leave thousands of dead entries in the 
> TSM.activeSocketSessions map. When I looked at an instance in a well-used 
> cluster yesterday, there were almost 400,000 entries in the map.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to