[ 
https://issues.apache.org/jira/browse/CASSANDRA-5171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703477#comment-13703477
 ] 

Jason Brown commented on CASSANDRA-5171:
----------------------------------------

I'm +1 on the v2 patch. As a minor nit, you might rename the "communication_ip" 
to something like "preferred_ip".

As an aside, I've never been thrilled with the default "UNKNOWN-DC" that can 
get returned when we don't know the DC. It's guaranteed to be wrong in almost 
all cases. However, I'm not sure what we'd do instead - returning null or empty 
string seems only slightly worse than the current default.
                
> Save EC2Snitch topology information in system table
> ---------------------------------------------------
>
>                 Key: CASSANDRA-5171
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5171
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.1
>         Environment: EC2
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Critical
>             Fix For: 1.2.7
>
>         Attachments: 0001-CASSANDRA-5171.patch, 0001-CASSANDRA-5171-v2.patch
>
>
> EC2Snitch currently waits for the Gossip information to understand the 
> cluster information every time we restart. It will be nice to use already 
> available system table info similar to GPFS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to