[ 
https://issues.apache.org/jira/browse/CASSANDRA-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704048#comment-13704048
 ] 

Dave Brosius commented on CASSANDRA-5734:
-----------------------------------------

patch looks fine, however formatting is off. Please use spaces, rather than 
tabs, and align with 4 spaces per indent.
                
> Print usage when command is not specified in nodetool instead of connection 
> failure
> -----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-5734
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5734
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>    Affects Versions: 1.2.6
>            Reporter: Manoj Mainali
>            Assignee: Manoj Mainali
>            Priority: Minor
>             Fix For: 1.2.7
>
>         Attachments: trunk-CASSANDRA-5734.patch
>
>
> nodetool command tries to establish connection to the cassandra node before 
> ensuring that the command is valid. Therefore, when no command is specified 
> it will print (in the case when C* is not running)
> {noformat}
> $ bin/nodetool
> Failed to connect to '127.0.0.1:7199': Connection refused
> {noformat}
> That means we need to have a running instance of C* to check the available 
> commands. But this is a syntax error and usage can be displayed (which is the 
> result even if a C* is running) even without a C* instance. Probably, it 
> would be better to make sure that the command sytnax is valid and print usage 
> if not. By doing this, we can easily check the available commands.
> Additionally, same should apply for the help command. Since, help will not be 
> connecting to the C* instance, we should not have a dependency on a running 
> C*.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to