[ 
https://issues.apache.org/jira/browse/CASSANDRA-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706972#comment-13706972
 ] 

Sylvain Lebresne commented on CASSANDRA-5542:
---------------------------------------------

On the protocol changes, I'm not sure I'm a big fan of adding 2 new stream 
messages just for the purpose of setting up connections. I was also liking the 
idea of having a setup phase that creates both connections before starting to 
use it, instead of creating one and partially using it to synchronize the 
creation of the other one as done in the patch.

What I had imagined is that the initiator could just create 2 connections 
(without really waiting for anything from the other side), sending a StreamInit 
on each with a flag saying if the connection is the incoming or ongoing one. On 
receiving any of those connection, the other side would fetch the session and 
attach the connection if it's the second one, or create the session if it's the 
first one. The initiator could then start the prepare phase as soon as both 
connection are open (without waiting for any special message from the other 
side). Seems a bit simpler to me overall.

What do you think?

The 2nd patch lgtm.

                
> BulkLoader is broken in trunk
> -----------------------------
>
>                 Key: CASSANDRA-5542
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5542
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 2.0 beta 1
>            Reporter: Yuki Morishita
>            Assignee: Yuki Morishita
>             Fix For: 2.0
>
>         Attachments: 0001-change-streaming-procedure.patch, 
> 0002-make-BulkLoader-work-with-SSTableReader.patch, 5542-fix-NPE.txt, 5542.txt
>
>
> After CASSANDRA-5015 and CASSANDRA-5521, we need CFMetaData to open 
> SSTable(Reader), especially to get bloom_filter_fp_chance and index_interval.
> When using bulkloader, CFMetaData is not available, so we cannot open SSTable 
> to be streamed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to