[ 
https://issues.apache.org/jira/browse/CASSANDRA-5746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712775#comment-13712775
 ] 

Jonathan Ellis commented on CASSANDRA-5746:
-------------------------------------------

LGTM, committed.  (Tweaked to use LoadingCache.getUnchecked instead of manually 
throwing RTE ourselves, also in the existing incrPastWindow.)
                
> HHOM.countPendingHints is a trap for the unwary
> -----------------------------------------------
>
>                 Key: CASSANDRA-5746
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5746
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core, Tools
>            Reporter: Jonathan Ellis
>            Assignee: Tyler Hobbs
>             Fix For: 2.0 beta 2
>
>         Attachments: 0001-Remove-HHOM.countPendingHints.patch, 
> 0002-Report-created-hint-count-by-endpoint.patch
>
>
> countPendingHints can OOM the server fairly easily since it does a per-target 
> seq scan without paging.
> More generally, countPendingHints is far too slow to be useful for routine 
> monitoring.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to