[
https://issues.apache.org/jira/browse/CASSANDRA-5084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721468#comment-13721468
]
Dave Brosius commented on CASSANDRA-5084:
-----------------------------------------
Couple of points of note:
This patch doesn't interact with the native interface, which going forward
in trunk would seem to be more relevant. At the least that probably means the
JMX name shouldn't include 'thrift'. connections? something else.
Rather than returning error strings, probably would be better to just throw
RuntimeExceptions, as programmatically you wouldn't be able to tell that "No
active connection found for given host and port" wasn't a user name. Sure it
looks fine in jconsole, but i'm talking about a programatic access.
Creating a ThriftSessionManager field in CassandraServer doesn't seem necessary
just to make sure that it is loaded first. One would think you could just do
something like
ThriftSessionManager.instance.hashCode() in the CassandraServer ctor.
When i saw the word 'Active' in the jmx names, i immediately assumed you were
talking about how many clients had code running for them in the server at the
present time. I'm not sure if there's a better word for what you are reporting
or not. In addition, with connection pooling, these numbers maybe larger than
expected, so is that statistic of use? Or do you really want active use
connections?
Is there any concern about exposing user identity thru jmx? probably not, just
asking.
As soon as you do expose this however, admins will want the ability to kill a
specific users connection :)
small nit, the import order is
java
javax
3rdparties
cassandra
> Cassandra should expose connected client state via JMX
> ------------------------------------------------------
>
> Key: CASSANDRA-5084
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5084
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Coli
> Priority: Minor
> Labels: lhf
> Attachments: 5084-trunk.patch
>
>
> There is currently no good way to determine or estimate how many clients are
> connected to a cassandra node without using netstat or (if using sync thrift
> server) counting threads. There is also no way to understand what state any
> given connection is in. People regularly come into #cassandra/cassandra-user@
> and ask how to get the equivalent of a MySQL "SHOW FULL PROCESSLIST."
> While I understand that feature parity with SHOW FULL
> PROCESSLIST/information_schema.processlist is unlikely, even a few basic
> metrics like "number of connected clients" or "number of active clients"
> would greatly help with this operational information need.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
