[
https://issues.apache.org/jira/browse/CASSANDRA-5800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735401#comment-13735401
]
Aleksey Yeschenko commented on CASSANDRA-5800:
----------------------------------------------
Huh, let me bikeshed a little as well:
- catching NPE there is bad, idiomatically we check row.has(String column)
first instead
- (key_alias != null && key_aliases == null) is not comprehensive enough. if
key_alias is null, we still want to set key_aliases (to '[]'). so it should be
if (key_aliases == null) instead.
- with the above in place, all the special-casing for key_aliases being null
and all the references to key_alias should be dropped from the 2.0 codebase
entirely, assuming that we already mandate 1.2.9 for upgraders
> Support pre-1.2 release CQL3 tables in CqlPagingRecordReader
> ------------------------------------------------------------
>
> Key: CASSANDRA-5800
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5800
> Project: Cassandra
> Issue Type: Bug
> Components: Hadoop
> Affects Versions: 1.2.6
> Reporter: Alex Liu
> Assignee: Alex Liu
> Priority: Minor
> Fix For: 1.2.9
>
> Attachments: 5800-1.2-branch.txt, 5800-2-1.2-branch.txt
>
>
> Pre-1.2 release CQL3 table stores the key in system.schema_columnfamilies
> key_alias column which is different from 1.2 release. We should support it in
> CqlPagingRecordReader as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
