[ 
https://issues.apache.org/jira/browse/CASSANDRA-6417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834604#comment-13834604
 ] 

Sylvain Lebresne commented on CASSANDRA-6417:
---------------------------------------------

Looks good, but when testing for column deletions in ColumnIndex, it would be 
slightly more efficient to use DeletionInfo.inOrderTester.

Nit: in ColumnIndex comments, "This is a *morge* general ...".


> Make flush single-pass when partition tombstones are present
> ------------------------------------------------------------
>
>                 Key: CASSANDRA-6417
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6417
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: 6417.txt
>
>
> CASSANDRA-2589 added some code to make sure we don't write cell tombstones 
> that are shadowed by a partition tombstone, by iterating over the CF object 
> and removing them, before iterating again to write the remaining cells to 
> disk.
> We can simplify this at the same time as we generalize this to all shadowed 
> cells.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to