[
https://issues.apache.org/jira/browse/CASSANDRA-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13845701#comment-13845701
]
Tyler Hobbs commented on CASSANDRA-6086:
----------------------------------------
[~yukim] the patch looks pretty good. Can you add a test like
{{ColumnFamilyStoreTest.testRemoveUnifinishedCompactionLeftovers()}} to cover
this? Also, warning logs should either suggest an action or let the user know
that no action is required; in this case, we should tell the user to report the
issue but that no corrective action is needed.
> Node refuses to start with exception in
> ColumnFamilyStore.removeUnfinishedCompactionLeftovers when find that some to
> be removed files are already removed
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-6086
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6086
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Oleg Anastasyev
> Assignee: Yuki Morishita
> Fix For: 2.0.4
>
> Attachments: 6086-v2.txt, removeUnfinishedCompactionLeftovers.txt
>
>
> Node refuses to start with
> {code}
> Caused by: java.lang.IllegalStateException: Unfinished compactions reference
> missing sstables. This should never happen since compactions are marked
> finished before we start removing the old sstables.
> at
> org.apache.cassandra.db.ColumnFamilyStore.removeUnfinishedCompactionLeftovers(ColumnFamilyStore.java:544)
> at
> org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:262)
> {code}
> IMO, there is no reason to refuse to start discivering files that must be
> removed are already removed. It looks like pure bug diagnostic code and mean
> nothing to operator (nor he can do anything about this).
> Replaced throw of excepion with dump of diagnostic warning and continue
> startup.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
