[
https://issues.apache.org/jira/browse/CASSANDRA-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860297#comment-13860297
]
Benedict commented on CASSANDRA-6281:
-------------------------------------
Don't even need to apply the patch to see it looks good. Every "-" line is
matched by a semantically identical "+" line, except in DWRH, which is almost
identical and definitely fine.
Note, I did apply it, just to make sure. Everything looks hunkydory.
I'm comfortable about applying it to 2.0.5, the patch is about as safe as they
come, although I think the benefit is actually fairly minimal so I don't think
it is urgent. Overall contribution to memory consumption of these fields in the
2.0 branch is going to be really minimal given, probably ~2% or less of
memtable consumption on average.
The only thing I would say is that the "receive = 0" assignment in ReadCallback
is unnecessary.
> Use Atomic*FieldUpdater to save memory
> --------------------------------------
>
> Key: CASSANDRA-6281
> URL: https://issues.apache.org/jira/browse/CASSANDRA-6281
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Marcus Eriksson
> Assignee: Marcus Eriksson
> Priority: Minor
> Fix For: 2.1
>
> Attachments: 0001-Use-Atomic-FieldUpdater-to-save-memory.patch
>
>
> Followup to CASSANDRA-6278, use Atomic*FieldUpdater in;
> AtomicSortedColumns
> ReadCallback
> WriteResponseHandler
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
